New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run isothermal Soret channel as a test #441

Draft

baperry2 wants to merge 4 commits into AMReX-Combustion:development from baperry2:soret-isothermal-test

Collaborator

baperry2 commented Nov 20, 2024

Add case from #391 to run in CI

TODO:

modify python validation script to ensure species conservation for this case
Document peculiarities (no wbar for Soret + Isothermal domain boundary, Soret + isothermal EB not supported, but shouldn't lead to conservation issues)

baperry2 added 4 commits

December 17, 2024 11:27


          run isothermal Soret channel as a test

b1eb277


          fix warns


          remove unused input from isothermal soret

8823cbb


          remove more unused

db25cf2

baperry2 force-pushed the soret-isothermal-test branch from 1dc3b25 to db25cf2 Compare

December 17, 2024 18:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet